[issue 679][oauth2] Fix macos compiler warnings, remove store impleme…#737
[issue 679][oauth2] Fix macos compiler warnings, remove store impleme…#737llqgit wants to merge 1 commit intoapache:masterfrom
Conversation
…nt keyring which not used at all
|
Any change to confirm PR ? |
|
@wolfstudy can you confirm this PR? thanks |
|
cc @zymap Please take a look thanks |
zymap
left a comment
zymap
left a comment
There was a problem hiding this comment.
It's a persistent implementation, we shouldn't remove it. It's an option of the store implementation, user can choose by themselves.
|
@zymap I got it and understand your point. If it should be kept for the users which choose this implementation, now what's your opinion about the users not use this extra implementation and still shown the warning below? It is really annoying when you develop and run the program in every time.
|
|
I saw the author has fixed this issue(keybase/go-keychain#76). Could you please try to upgrade the dependency to check if it works? |
|
@zymap I just run: This is the official way to init, it should be all right.
If I run my program, the errors shown like this: You said the new version of The version would be: It should be good. But I got some new errors which looks worse:
By the way. My mac OS version
From my perspective, the warning problem was not fixed yet or not effective. |
|
@llqgit I think they remove the support to avoid the warning. keybase/go-keychain#76 |
7 participants
…nt keyring which not used at all
Master Issue: #719
Motivation
Fix MacOS version warning from the unused OAuth2 store implement named keyring.go
Modifications
To fix the warning that on MacOS once for all by remove the
keyring.gowhich no references from other places, rather than upgrade the keyring package.Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
github.com/99designs/go-keychainDocumentation